{{ message }}
[3.11] GH-93516: Speedup line number checks when tracing. (GH-93763)#94023
Closed
markshannon wants to merge 1 commit intopython:3.11from
Closed
[3.11] GH-93516: Speedup line number checks when tracing. (GH-93763)#94023markshannon wants to merge 1 commit intopython:3.11from
markshannon wants to merge 1 commit intopython:3.11from
Conversation
Member
Author
| self.write(f".co_name = {co_name},") | ||
| self.write(f".co_qualname = {co_qualname},") | ||
| self.write(f".co_linetable = {co_linetable},") | ||
| self.write("._co_linearray = NULL,") |
Member
There was a problem hiding this comment.
Sorry, unrelated question, but does this mean I need to add the field from my _co_code change here too?
Member
Author
There was a problem hiding this comment.
Technically, no. C will initialize any fields not explicitly mentioned to zero.
I think it is good practice to be explicit, though.
Member
|
I will regenerate the ABI in this PR |
Member
|
@markshannon I cannot push to the remote repo, could you please ensure the "allow pushes from maintainers checkbox is activated on the right column"? |
Member
Author
|
There is no "allow pushes from maintainers" checkbox. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #93763