{{ message }}
gh-84694: Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS#93185
Merged
ericsnowcurrently merged 5 commits intopython:mainfrom May 27, 2022
Merged
gh-84694: Drop EXPERIMENTAL_ISOLATED_SUBINTERPRETERS#93185ericsnowcurrently merged 5 commits intopython:mainfrom
ericsnowcurrently merged 5 commits intopython:mainfrom
Conversation
Member
corona10
reviewed
May 25, 2022
Member
There was a problem hiding this comment.
If we decide to remove this flag, I would like to recommend adding the entry for What's NEWS.
Although this flag was not intended to expose to the public user, this flag was spread out to users who have interests in the multi-core sub interpreter project.
example: https://stackoverflow.com/a/65995393
Contributor
|
This is also broken on main branch and 3.11 as it won't even compile with this option. See #90988 |
Member
|
Yes, please. |
Member
Author
|
@pablogsal, would it be okay to backport this to 3.11? (It already doesn't work on 3.11 currently.) |
Member
|
Yep, I'm ok backporting this 👍 |
Contributor
|
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Contributor
ericsnowcurrently
added a commit
to ericsnowcurrently/cpython
that referenced
this pull request
May 28, 2022
…-93185) This was added for bpo-40514 (pythongh-84694) to test out a per-interpreter GIL. However, it has since proven unnecessary to keep the experiment in the repo. (It can be done as a branch in a fork like normal.) So here we are removing: * the configure option * the macro * the code enabled by the macro
miss-islington
pushed a commit
that referenced
this pull request
May 28, 2022
… (GH-93306) (cherry picked from commit caa279d) This was added for bpo-40514 (gh-84694) to test out a per-interpreter GIL. However, it has since proven unnecessary to keep the experiment in the repo. (It can be done as a branch in a fork like normal.) So here we are removing: * the configure option * the macro * the code enabled by the macro Automerge-Triggered-By: GH:ericsnowcurrently
CAM-Gerlach
added a commit
to CAM-Gerlach/cpython
that referenced
this pull request
Oct 16, 2022
/ pythongh-93306 Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
miss-islington
pushed a commit
that referenced
this pull request
Oct 17, 2022
Part of #95913 Forward port of #93306, which was a backport of #93185, to address #84694 This adds the What's New entry for the removal of the subinterpreter-related env variable, build-time flag, etc. As @ericsnowcurrently was author of the original changes, I added him as a co-author to the commit. This addition to the Python 3.11 What's New document were only made to the Python 3.11 branch during the backport process, and not added to the version in `main`. Forward-porting it ensures the docs retain these additions for the future, rather than being lost in a legacy Python versions, allows it to be be edited as part of #95913 , and avoids merge conflicts with routine back-ports of PRs touching it. I've pulled in the addition exactly as-is with no modifications; any editing will be done in future PRs (and therefore can be reviewed and backported accordingly). The one other such addition is forward-ported in #98344
terryjreedy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added for bpo-40514 (gh-84694) to test out a per-interpreter GIL. However, it has since proven unnecessary to keep the experiment in the repo. (It can be done as a branch in a fork like normal.) So here we are removing: