{{ message }}
gh-92525: make inspect.getfile PEP 420 compliant - #92635
Open
carlbordum wants to merge 3 commits into
Open
Conversation
serhiy-storchaka
requested changes
May 11, 2022
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Please add a test and a NEWS entry.
carlbordum
force-pushed
the
92525-inspect-getfile-pop-420
branch
from
May 11, 2022 15:54
0efd3c7 to
89b2b45
Compare
Contributor
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @serhiy-storchaka: please review the changes made to this pull request. |
carlbordum
force-pushed
the
92525-inspect-getfile-pop-420
branch
from
May 21, 2022 19:07
89b2b45 to
0b4953e
Compare
carlbordum
force-pushed
the
92525-inspect-getfile-pop-420
branch
2 times, most recently
from
September 1, 2022 18:48
e8c07a1 to
d6b227d
Compare
carlbordum
force-pushed
the
92525-inspect-getfile-pop-420
branch
from
September 1, 2022 19:39
d6b227d to
9aaf28c
Compare
Contributor
Author
|
What do you think of this? Should something more be tested? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #92525
inspect.getfiledoesn't properly handle PEP 420 #92525