{{ message }}
Conversation
Author
Contributor
|
Hi @prudvinit, thanks for opening a PR. I'm not sure that your fix is correct but "test coverage" means writing a test to show code that was broken by the previous behavior of the function you changed so The tests for the pathlib module are in test_pathlib.py, you can look at the other tests of |
Author
|
Hi
I'd like to continue working on that. I'll add whatever is required and
reach out to you if I need any help.
Thanks
Prudvi M
…On Fri, May 24, 2019, 8:32 PM Rémi Lapeyre ***@***.***> wrote:
Hi @prudvinit <https://github.com/prudvinit>, thanks for opening a PR.
I'm not sure that your fix is correct but "test coverage" means writing a
test to show code that was broken by the previous behavior of the function
you changed so iterdir() in your case, and that your changed fixed. This
serves multiple purposes, it shows the bug, shows your solution work and
the test will fail if someone make another change that ends up breaking
your fix.
The tests for the pathlib module are in test_pathlib.py, you can look at
the other tests of iterdir() to try and write your own. I would be happy
to help you if you get stuck.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8999?email_source=notifications&email_token=AEFGHU27DOCT2C7DLXMV6ZDPW77QHA5CNFSM4FSH3LD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFUUMQ#issuecomment-495667762>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEFGHU5STUK6MOWHEYLXZXTPW77QHANCNFSM4FSH3LDQ>
.
|
Member
|
@prudvinit are you still working on this? Otherwise, could we close the PR so that someone else may pick it up? |
Author
|
Hi Katriel.
Haven't worked on it for a while. I'll work on it during the weekend and
try to finish it. I'll keep you updated,
Thanks
Prudvi M
…On Fri, May 21, 2021 at 7:42 PM Irit Katriel ***@***.***> wrote:
@prudvinit <https://github.com/prudvinit> are you still working on this?
Otherwise, could we close the PR so that someone else may pick it up?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8999 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFGHU5FMQ4XF43KQHQSOS3TOZS5PANCNFSM4FSH3LDQ>
.
|
Contributor
|
Hey @prudvinit - do you think you might have time to resolve conflicts and add tests? This looks like a useful fix! |
AlexWaygood
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.