bpo-33898: Fix pathlib issues with Windows device paths by AlbinaGiliazova · Pull Request #8671 · python/cpython · GitHub
Skip to content

bpo-33898: Fix pathlib issues with Windows device paths#8671

Closed
AlbinaGiliazova wants to merge 17 commits intopython:mainfrom
AlbinaGiliazova:bpo-33898-fix
Closed

bpo-33898: Fix pathlib issues with Windows device paths#8671
AlbinaGiliazova wants to merge 17 commits intopython:mainfrom
AlbinaGiliazova:bpo-33898-fix

Conversation

@AlbinaGiliazova
Copy link
Copy Markdown

@AlbinaGiliazova AlbinaGiliazova commented Aug 4, 2018

https://bugs.python.org/issue33898
Now it should work correctly for all mentioned test examples but no changes made for GlobalRoot case as no examples were provided.

https://bugs.python.org/issue33898

@the-knights-who-say-ni
Copy link
Copy Markdown

@AlbinaGiliazova
Copy link
Copy Markdown
Author

Wow! It passed whitespace checks finally. I thought it's impossible. Btw CLA is signed but waiting for approvement.

Copy link
Copy Markdown
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this patch! A couple of minor suggestions, and a question or two.

Comment thread Lib/pathlib.py Outdated
Comment thread Lib/pathlib.py Outdated
Comment thread Lib/pathlib.py Outdated
Comment thread Lib/pathlib.py
Comment thread Lib/pathlib.py Outdated
Comment thread Lib/pathlib.py Outdated
@AlbinaGiliazova
Copy link
Copy Markdown
Author

I've made the improvements requested. Should I do something else or just wait for another review?

@csabella
Copy link
Copy Markdown
Contributor

@zooba It appears that @AlbinaGiliazova addressed all your review concerns. Would you have an opportunity to review the changes? Thanks!

Copy link
Copy Markdown
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping! We're nearly there, just little nits that we don't want making it into the codebase.

Comment thread Lib/pathlib.py Outdated
Comment thread Lib/pathlib.py Outdated
Comment thread Lib/pathlib.py Outdated
Comment thread Lib/pathlib.py Outdated
Comment thread Lib/pathlib.py Outdated
@csabella
Copy link
Copy Markdown
Contributor

@eryksun, would you be able to review this per @zooba's request on the bug tracker. Thanks!

@eryksun
Copy link
Copy Markdown
Contributor

eryksun commented May 24, 2019

@csabella, thanks for the reminder. I missed the tracker notification.

@csabella
Copy link
Copy Markdown
Contributor

@eryksun, ping

@AlbinaGiliazova
Copy link
Copy Markdown
Author

Hello. How do I make backports. Is there an instruction?

@csabella
Copy link
Copy Markdown
Contributor

@AlbinaGiliazova, you wouldn't need to do anything for the backports unless the bot is unable to create them.

@barneygale
Copy link
Copy Markdown
Contributor

Code looks good to me, but this needs tests!

@ambv
Copy link
Copy Markdown
Contributor

ambv commented May 17, 2022

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@barneygale
Copy link
Copy Markdown
Contributor

@barneygale barneygale closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants