bpo-33898: Fix pathlib issues with Windows device paths#8671
bpo-33898: Fix pathlib issues with Windows device paths#8671AlbinaGiliazova wants to merge 17 commits intopython:mainfrom
Conversation
Create 2018-08-04-15-04-10.bpo-33898.psrYKd.rst
|
Wow! It passed whitespace checks finally. I thought it's impossible. Btw CLA is signed but waiting for approvement. |
zooba
left a comment
There was a problem hiding this comment.
Thanks for doing this patch! A couple of minor suggestions, and a question or two.
|
I've made the improvements requested. Should I do something else or just wait for another review? |
|
@zooba It appears that @AlbinaGiliazova addressed all your review concerns. Would you have an opportunity to review the changes? Thanks! |
zooba
left a comment
There was a problem hiding this comment.
Thanks for the ping! We're nearly there, just little nits that we don't want making it into the codebase.
|
@csabella, thanks for the reminder. I missed the tracker notification. |
|
@eryksun, ping |
|
Hello. How do I make backports. Is there an instruction? |
|
@AlbinaGiliazova, you wouldn't need to do anything for the backports unless the bot is unable to create them. |
|
Code looks good to me, but this needs tests! |
|
This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today. |

https://bugs.python.org/issue33898
Now it should work correctly for all mentioned test examples but no changes made for GlobalRoot case as no examples were provided.
https://bugs.python.org/issue33898