{{ message }}
bpo-20602: Do not clear sys.flags and sys.float_info during shutdown - #8096
Merged
encukou merged 1 commit intoMay 30, 2019
Merged
Conversation
serhiy-storchaka
previously requested changes
Oct 12, 2018
Contributor
Author
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @serhiy-storchaka: please review the changes made to this pull request. |
tiran
approved these changes
May 29, 2019
tiran
left a comment
tiran
left a comment
Member
There was a problem hiding this comment.
LGTM
The PR has been dormant for a while. Do you want to land it in 3.8?
Contributor
Author
|
Thanks for the review, @tiran. For what it's worth, I would like to see this land in 3.8. |
Member
There is no need to clear these immutable objects during shutdown.
ZackerySpytz
force-pushed
the
bpo-20602-sys-flags-sys-float_info-clear
branch
from
May 29, 2019 21:20
dd4b698 to
932feb6
Compare
ZackerySpytz
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
May 29, 2019 21:20
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…ythonGH-8096) There is no need to clear these immutable objects during shutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to clear these immutable objects during shutdown.
https://bugs.python.org/issue20602