{{ message }}
python/core-workflow#2: Add test coverage reporting for C files - #7773
Merged
Conversation
Member
Author
brettcannon
self-requested a review
June 18, 2018 19:00
methane
self-requested a review
June 19, 2018 03:22
methane
approved these changes
Jun 19, 2018
Member
|
I afraid that test will go slower than Travis's time limit. |
Member
Author
|
Alternatively, we can also split the test suite in half and run them in seperate builds. Codecov takes care of merging the coverage results, so we could have the first ~200 or so tests run in one build and the remaining ~200 in another. I'll monitor the travis builds after this to make sure we don't hit the 50 minute limit. |
brettcannon
approved these changes
Jun 22, 2018
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nitty gritty on the details here: python/core-workflow#2 (comment)