bpo-29481: DOC: mark which version typing.Deque added by tacaswell · Pull Request #61 · python/cpython · GitHub
Skip to content

bpo-29481: DOC: mark which version typing.Deque added#61

Closed
tacaswell wants to merge 1 commit intopython:masterfrom
tacaswell:doc_deque_vadded
Closed

bpo-29481: DOC: mark which version typing.Deque added#61
tacaswell wants to merge 1 commit intopython:masterfrom
tacaswell:doc_deque_vadded

Conversation

@tacaswell
Copy link
Copy Markdown
Contributor

@tacaswell tacaswell commented Feb 13, 2017

This is targeted at 3.6, but half of it should be backported to 3.5.

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Feb 13, 2017

@tacaswell tacaswell changed the base branch from master to 3.6 February 13, 2017 04:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2017 •
edited
Loading

Codecov Report

Merging #61 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   82.37%   82.37%   +<.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
+ Hits       289091   289095       +4     
+ Misses      61857    61853       -4
Impacted Files Coverage Δ
Lib/heapq.py 96.56% <ø> (-0.77%) ❌
Lib/threading.py 82.6% <ø> (-0.18%) ❌
Lib/test/test_smtplib.py 86.71% <ø> (+0.22%) ✅
Lib/test/test_strptime.py 95.01% <ø> (+0.26%) ✅
Lib/_strptime.py 95.01% <ø> (+0.33%) ✅
Lib/test/test_thread.py 66.83% <ø> (+0.51%) ✅
Lib/test/test_capi.py 92.5% <ø> (+0.55%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649a7ca...5dd1ab0. Read the comment docs.

berkerpeksag
berkerpeksag requested changes Feb 13, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've re-targeted this to master branch. We can then backport this to 3.6. For 3.5, we'll need a separate PR that adds .. versionadded:: 3.5.4.

Comment thread Doc/library/typing.rst Outdated
Copy link
Copy Markdown
Member

@berkerpeksag berkerpeksag Feb 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 3.6 docs, we can remove .. versionadded:: 3.5.4.

@berkerpeksag berkerpeksag changed the base branch from 3.6 to master February 13, 2017 11:26
@tacaswell
Copy link
Copy Markdown
Contributor Author

tacaswell commented Feb 13, 2017

Should the 3.5 one also target master?

@tacaswell
Copy link
Copy Markdown
Contributor Author

tacaswell commented Feb 13, 2017

fixed and force-pushed.

I am currently running the CLA by my employer, it may be faster to just have someone else do this (given how minor it is).

@berkerpeksag
Copy link
Copy Markdown
Member

berkerpeksag commented Feb 13, 2017

Should the 3.5 one also target master?

3.5 should be against 3.5 branch, but don't worry about that :) Core developers can do the 3.5 backport.

@tacaswell
Copy link
Copy Markdown
Contributor Author

tacaswell commented Feb 15, 2017

@tacaswell tacaswell closed this Feb 15, 2017
@tacaswell tacaswell deleted the doc_deque_vadded branch February 15, 2017 13:32
@gvanrossum gvanrossum mentioned this pull request Apr 10, 2022
Closed
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Add more unittests (GH-61)
acf5c06
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@warsaw
Backport fix for test isolation from Python 3.8/3.7. Closes python#61
a4f0d6e
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@warsaw
Merge branch 'issue61' into 'master'
14d8cd8 
Backport fix for test isolation from Python 3.8/3.7

Closes python#61

See merge request python-devs/importlib_resources!63
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@hugovk
Update base URL for PEPs (python#61)
a4f5b76
isidentical pushed a commit to isidentical/cpython that referenced this pull request Mar 30, 2023
@pablogsal
Merge pull request python#61 from isidentical/solve-conversion-handle
59ec33d
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
@LinanV LinanV mentioned this pull request Oct 23, 2023
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Closed
This was referenced Feb 11, 2025
Open
Closed
AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull request Apr 10, 2025
@davepeck
Fix for segv in _PyInterpolation_FromStackRefSteal (python#61)
e6d01ef
@sergey-miryanov sergey-miryanov mentioned this pull request Dec 18, 2025
Open
@ngoldbaum ngoldbaum mentioned this pull request Mar 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tacaswell @the-knights-who-say-ni @berkerpeksag