bpo-32898: Fix debug build crash with COUNT_ALLOCS by eduardo-elizondo · Pull Request #5800 · python/cpython · GitHub
Skip to content

bpo-32898: Fix debug build crash with COUNT_ALLOCS - #5800

Merged
benjaminp merged 5 commits into
python:masterfrom
eduardo-elizondo:master
Feb 22, 2018
Merged

benjaminp merged 5 commits into
python:masterfrom
eduardo-elizondo:master

Conversation

@eduardo-elizondo

@eduardo-elizondo eduardo-elizondo commented Feb 21, 2018

Copy link
Copy Markdown
Contributor

The following build crashed:
mkdir debug && cd debug
../configure --with-pydebug
make EXTRA_CFLAGS="-DCOUNT_ALLOCS"

The bug was introduced in: 25420fe

Fix:

  1. s/inter/interp/
  2. Declare PyTypeObject

https://bugs.python.org/issue32898

@the-knights-who-say-ni

Copy link
Copy Markdown

@eduardo-elizondo eduardo-elizondo changed the title [Build] Fix debug build errors bpo-32898: Fix debug build errors Feb 21, 2018
@eduardo-elizondo eduardo-elizondo changed the title bpo-32898: Fix debug build errors bpo-32898: Fix debug build errors (no news) Feb 21, 2018
@eduardo-elizondo

Copy link
Copy Markdown
Contributor Author

Signed CLA. It should be ready within a couple of hours?

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Feb 21, 2018
@serhiy-storchaka

Copy link
Copy Markdown
Member

Yes, it should be ready within a couple of hours.

Please add your name in Misc/ACKS and add a news entry (you can use the blurb utility as described in the developer guide).

@eduardo-elizondo eduardo-elizondo changed the title bpo-32898: Fix debug build errors (no news) bpo-32898: Fix debug build errors Feb 21, 2018
@eduardo-elizondo eduardo-elizondo changed the title bpo-32898: Fix debug build errors bpo-32898: Fix debug build crash with COUNT_ALLOCS Feb 21, 2018
@eduardo-elizondo

Copy link
Copy Markdown
Contributor Author

Ready!

@benjaminp
benjaminp merged commit 745dc65 into python:master Feb 22, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @eduardo-elizondo for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2018
)

(cherry picked from commit 745dc65)

Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

miss-islington added a commit that referenced this pull request Feb 22, 2018
(cherry picked from commit 745dc65)

Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants