bpo-29749: Outdated int docstring - #565
Conversation
|
@svelankar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mdickinson, @serhiy-storchaka, @tim-one, @brettcannon and @benjaminp to be potential reviewers. |
|
The docstring is actually correct: So closing this. |
|
The docstring has the x parameter as a keyword which is no longer correct, and that is what the PR is fixing. |
|
@bitdancer but it also dropped the default arg, so shouldn't it be |
|
"or return 0 if no arguments are given" - This is from the docstring. Wouldn't this suffice to indicate that the positional argument is optional ? |
|
@svelankar no because if you are quickly glancing at the docstring just for the signature to e.g. remember argument orders and such then you won't bother reading the whole docstring. |
|
Ok. Please let me know if int([x]) is the only change you would like to see. |
|
Nope, I think that minor change is all that's necessary. |
|
Oh, and please sign the CLA. |
|
Done. |
|
Thanks for all the work on this, @svelankar ! |
* Fix status check comment for timed out or failed checks * Fix coverage issue * Remove unrelated change * Last unrelated change * Update tests/test_status_change.py Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

int docstring is the only one that needs to be changed. docstrings for float,tuple and list look fine to me.
Please review.