{{ message }}
bpo-32030: Add _PyCoreConfig.module_search_paths - #4954
Merged
Conversation
Member
Author
Member
Author
|
In other pull requests (now merged), I modified _PyPathConfig_Calculate() to not use the Python API internally, but only regular C functions. I rebased this PR on top of it. But I'm not sure that @ncoghlan likes this change. I will wait his feedback before merging this PR. |
vstinner
changed the title
Member
Author
|
test_site fails on AppVeyor. |
Contributor
|
While I initially thought this might conflict with some future plans I had
for refactoring how we configure the import system at startup, an off-list
discussion with Victor convinced me that was not the case.
So while I haven't reviewed the details of the PR (still on vacation!), I'm
OK with the idea in principle.
|
_PyCoreConfig_Read() is now responsible to compute sys.path. So sys.path is now computed before calling _Py_InitializeCore(). Changes: * Add nmodule_search_path, module_search_paths, executable, prefix, base_prefix, exec_prefix and base_exec_prefix to _PyCoreConfig * _PyMainInterpreterConfig_Read() now only converts wchar_t** lists into a Python list, it doesn't compute sys.path anymore.
Member
Author
|
I rebased my PR. |
Calling _PyCoreConfig_Read() requires to set global configuration variables, and then get again updated global configuration variables.
vstinner
changed the title
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyCoreConfig_Read() is now responsible to compute sys.path.
So sys.path is now computed before calling _Py_InitializeCore().
Changes:
base_prefix, exec_prefix and base_exec_prefix to _PyCoreConfig
into a Python list, it doesn't compute sys.path anymore.
https://bugs.python.org/issue32030