bpo-29240, bpo-32030: pymain_set_sys_argv() now copies argv by vstinner · Pull Request #4838 · python/cpython · GitHub
Skip to content

bpo-29240, bpo-32030: pymain_set_sys_argv() now copies argv - #4838

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:pymain_argv
Dec 13, 2017
Merged

bpo-29240, bpo-32030: pymain_set_sys_argv() now copies argv#4838
vstinner merged 1 commit into
python:masterfrom
vstinner:pymain_argv

Conversation

@vstinner

@vstinner vstinner commented Dec 13, 2017

Copy link
Copy Markdown
Member
  • Rename pymain_set_argv() to pymain_set_sys_argv()
  • pymain_set_sys_argv() now creates of copy of argv and modify the
    copy, rather than modifying pymain->argv
  • Call pymain_set_sys_argv() earlier: before pymain_run_python(), but
    after pymain_get_importer().
  • Add _PySys_SetArgvWithError() to handle errors

https://bugs.python.org/issue29240

bpo-29240, bpo-32030:

* Rename pymain_set_argv() to pymain_set_sys_argv()
* pymain_set_sys_argv() now creates of copy of argv and modify the
  copy, rather than modifying pymain->argv
* Call pymain_set_sys_argv() earlier: before pymain_run_python(), but
  after pymain_get_importer().
* Add _PySys_SetArgvWithError() to handle errors
@vstinner

Copy link
Copy Markdown
Member Author

@vstinner

Copy link
Copy Markdown
Member Author

@vstinner
vstinner merged commit d5dda98 into python:master Dec 13, 2017
@vstinner
vstinner deleted the pymain_argv branch December 13, 2017 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants