{{ message }}
Remove nested comments in blake2 - #4173
Merged
Merged
Conversation
Replace occurence of nested comments in blake2 reference implementation with preprocessor directive for disabling unused code. `blake2s-load-xop.h` is conditionally pulled in only on chips with XOP support, among others the AMD Bulldozer. The malformed comments in the source file breaks the build of `hashlib`'s `_blake2` on GCC 6.3.0. Official reference code on github uses `#if` so this change should be uncontroversial.
Contributor
Author
|
Signed CLA earlier today so that's in the pipeline if that's needed for this kind of custodial change. |
Contributor
Author
|
BLAKE2 reference impl: https://github.com/BLAKE2/BLAKE2/blob/master/sse/blake2s-load-xop.h#L20-L31 |
tiran
approved these changes
Nov 1, 2017
tiran
left a comment
tiran
left a comment
Member
There was a problem hiding this comment.
OK, the fix is also present in BLAKE2 upstream.
tiran
added
needs backport to 3.6
skip issue
skip news
and removed
CLA not signed
labels
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 1, 2017
Replace occurence of nested comments in blake2 reference implementation with preprocessor directive for disabling unused code. `blake2s-load-xop.h` is conditionally pulled in only on chips with XOP support, among others the AMD Bulldozer. The malformed comments in the source file breaks the build of `hashlib`'s `_blake2` on GCC 6.3.0. Official reference code on github uses `GH-if` so this change should be uncontroversial. (cherry picked from commit 388cd85)
tiran
pushed a commit
that referenced
this pull request
Nov 1, 2017
Replace occurence of nested comments in blake2 reference implementation with preprocessor directive for disabling unused code. `blake2s-load-xop.h` is conditionally pulled in only on chips with XOP support, among others the AMD Bulldozer. The malformed comments in the source file breaks the build of `hashlib`'s `_blake2` on GCC 6.3.0. Official reference code on github uses `GH-if` so this change should be uncontroversial. (cherry picked from commit 388cd85)
embray
pushed a commit
to embray/cpython
that referenced
this pull request
Nov 9, 2017
Replace occurence of nested comments in blake2 reference implementation with preprocessor directive for disabling unused code. `blake2s-load-xop.h` is conditionally pulled in only on chips with XOP support, among others the AMD Bulldozer. The malformed comments in the source file breaks the build of `hashlib`'s `_blake2` on GCC 6.3.0. Official reference code on github uses `#if` so this change should be uncontroversial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace occurence of nested comments in blake2 reference implementation
with preprocessor directive for disabling unused code.
blake2s-load-xop.his conditionally pulled in only on chips with XOPsupport, among others the AMD Bulldozer. The malformed comments in the
source file breaks the build of
hashlib's_blake2on GCC 6.3.0.Official reference code on github uses
#ifso this change should beuncontroversial.