{{ message }}
bpo-31415: Improve caching of the importtime option. - #4138
Merged
serhiy-storchaka merged 7 commits intoNov 7, 2017
Merged
Conversation
brettcannon
approved these changes
Oct 26, 2017
ncoghlan
reviewed
Oct 27, 2017
ncoghlan
left a comment
ncoghlan
left a comment
Contributor
There was a problem hiding this comment.
The actual change looks good to me, but there's a now outdated comment that needs to be adjusted to match the new implementation (we know that the -X options will have been processed by the time Py_IsInitialized() returns true.
Contributor
There was a problem hiding this comment.
Is this comment still true? The check for Py_IsInitialized() below means that there now is a negative cache for ximporttime == 0.
Member
|
Please double check, but I think I've resolved the conflicts. I did not remove the comment that @ncoghlan pointed out, but I agree it should probably be removed. |
Try to resolve conflicts correctly.
Resolving conflicts in GH web ui is hard!
Contributor
|
If we don't fix the comment in this PR, I suspect the odds of fixing it later are pretty low :) |
Member
warsaw
approved these changes
Nov 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31415