{{ message }}
bpo-31877: Add _Py_LegacyLocaleDetected and _PyCoerceLegacyLocale to pylifecycle.h - #4134
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
If add declarations here they should be removed from Programs/python.c.
Contributor
Author
There was a problem hiding this comment.
Indeed; I just wonder if there was some reason this was done the way it was done in the first place. I can't see a good reason, particularly...
Contributor
There was a problem hiding this comment.
The only reason I did it that way was because they're private APIs intended specifically for the CPython CLI, and that code built OK in CI and on the buildbots.
However, since that turns out to cause problems on Cygwin, switching to the more conventional approach makes sense, and the private declarations can be dropped.
Contributor
Author
There was a problem hiding this comment.
Okay, thanks for the clarification.
Kept the explanatory comment but moved it to the relevant part of the code.
serhiy-storchaka
approved these changes
Oct 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial (?) fix for https://bugs.python.org/issue31877
https://bugs.python.org/issue31877