{{ message }}
bpo-30860: Fix a refleak. - #3506
Merged
Merged
Conversation
vstinner
approved these changes
Sep 11, 2017
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
In Py_Main(), read_command_line() is called after _Py_InitializeCore, so after the interpreter had been already created and after the sys module has been initialized.
For example, in Python 3.5, Py_Initialize() was only called after the command line has been parsed.
It seems like past changes now make this change possible and correct.
Member
vstinner
reviewed
Sep 12, 2017
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
If you use #ifdef Py_REF_DEBUG, maybe _PY_DEBUG_PRINT_TOTAL_REFS() macro can go away.
Member
Author
vstinner
approved these changes
Sep 12, 2017
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Ah yes, you removed the macro. Nice.
LGTM.
ericsnowcurrently
added a commit
to ericsnowcurrently/cpython
that referenced
this pull request
Sep 14, 2017
This reverts commit 8728018.
ericsnowcurrently
added a commit
that referenced
this pull request
Sep 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves bpo-31420.
https://bugs.python.org/issue30860