{{ message }}
bpo-31370: Remove support for threads-less builds - #3385
Merged
Merged
Conversation
pitrou
requested review from
a team,
1st1,
gpshead,
ncoghlan,
rhettinger and
skrah
as code owners
September 6, 2017 17:03
gpshead
approved these changes
Sep 6, 2017
gpshead
left a comment
Member
There was a problem hiding this comment.
yay! i skimmed over everything, it looks good. lots of mechanical changes. :)
vstinner
approved these changes
Sep 6, 2017
vstinner
left a comment
Member
There was a problem hiding this comment.
Please keep the "#define WITH_THREAD 1" for backward compatibily. Maybe in pyport.h?
LGTM if you keep the define, but I would like to see a review of another core dev like @ericsnowcurrently.
See https://bugs.python.org/issue27961#msg276881 and commit a251fb0.
bitdancer
reviewed
Sep 7, 2017
bitdancer
left a comment
Member
There was a problem hiding this comment.
The test_email change looks fine :)
I think this needs a mention in What's New as well.
Member
Author
Member
Author
Ok, done. |
Member
|
Thanks, I merged your change ;-) |
ma8ma
added a commit
to ma8ma/cpython
that referenced
this pull request
Sep 8, 2017
Resolve conflicts: a6a4dc8 bpo-31370: Remove support for threads-less builds (python#3385)
mcepl
pushed a commit
to openSUSE-Python/cpython
that referenced
this pull request
Apr 13, 2024
* Remove Setup.config * Always define WITH_THREAD for compatibility.
cjwatson
added a commit
to cjwatson/pastescript
that referenced
this pull request
Dec 8, 2024
python/cpython#109462 removed `logging._acquireLock`. Fortunately, python/cpython#3385 simplified lock creation so that `with logging._lock:` is sufficient; that PR made it into Python 3.7, which is already pastescript's minimum Python requirement.
cdent
pushed a commit
to pasteorg/pastescript
that referenced
this pull request
Jan 22, 2025
python/cpython#109462 removed `logging._acquireLock`. Fortunately, python/cpython#3385 simplified lock creation so that `with logging._lock:` is sufficient; that PR made it into Python 3.7, which is already pastescript's minimum Python requirement.
jjhelmus
added a commit
to jjhelmus/conda
that referenced
this pull request
Feb 11, 2025
Aquire the logging lock using the underlying _lock object from the logging module. As of python/cpython#3385, included in Python 3.7, this object an instance of threading.RLock whose use as a context manager with release being called when the block exits, see https://docs.python.org/3/library/threading.html#using-locks-conditions-and-semaphores-in-the-with-statement
jezdez
pushed a commit
to conda/conda
that referenced
this pull request
Feb 12, 2025
* aquire logging lock using _lock context manager Aquire the logging lock using the underlying _lock object from the logging module. As of python/cpython#3385, included in Python 3.7, this object an instance of threading.RLock whose use as a context manager with release being called when the block exits, see https://docs.python.org/3/library/threading.html#using-locks-conditions-and-semaphores-in-the-with-statement * mark conda.common.io._logger_lock for deprecation * add news * Update news/14584-use-logging-lock * Apply suggestions from code review --------- Co-authored-by: Daniel Holth <dholth@anaconda.com> Co-authored-by: Ken Odegard <kodegard@anaconda.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

https://bugs.python.org/issue31370