{{ message }}
Conversation
* bpo-31170: Update libexpat from 2.2.3 to 2.2.4 Fix copying of partial characters for UTF-8 input (libexpat bug 115): libexpat/libexpat#115 * Add NEWS entry. (cherry picked from commit 759e30e)
tiran
previously requested changes
Sep 5, 2017
tiran
left a comment
tiran
left a comment
Member
There was a problem hiding this comment.
Breaks Windows builds:
..\Modules\expat\xmltok.c(34): fatal error C1083: Cannot open include file: 'stdbool.h': No such file or directory [C:\projects\cpython\PCbuild\pyexpat.vcxproj]
The standard header stdbool.h is not available with old Visual Studio compilers Cherry-picked from libexpat b4b89c2ab0cc5325a41360c25ef9d2ccbe617e5c.
Member
Author
|
"Breaks Windows builds: ..\Modules\expat\xmltok.c(34): fatal error C1083: Cannot open include file: 'stdbool.h': No such file or directory [C:\projects\cpython\PCbuild\pyexpat.vcxproj]" I spent 15 minutes to write a fix for libexpat. But i was working on the 2.2.4 branch, in fact the bug is already fixed upstream: libexpat/libexpat@b4b89c2 So I cherry-picked the fix. |
…pilation. Cherry-picked from libexpat commit e0b290eb3d8f4c4b45137a7d7f4f8db812145bd2
vstinner
dismissed
tiran’s stale review
September 6, 2017 00:12
Yeah, tests pass on Windows (AppVeyor) :-)
Contributor
|
Thanks. Since this is going into 2.7.14 final, I'll deal with it. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix copying of partial characters for UTF-8 input (libexpat bug 115):
libexpat/libexpat#115
(cherry picked from commit 759e30e)
https://bugs.python.org/issue31170