{{ message }}
bpo-47215: Add undocumented, unstable FrameStack API for use by greenlets and similar libraries.#32303
Closed
markshannon wants to merge 5 commits intopython:mainfrom
Closed
bpo-47215: Add undocumented, unstable FrameStack API for use by greenlets and similar libraries.#32303markshannon wants to merge 5 commits intopython:mainfrom
markshannon wants to merge 5 commits intopython:mainfrom
Conversation
jdahlin
reviewed
Apr 4, 2022
Contributor
There was a problem hiding this comment.
What about hiding this behind an ifdef, it would technically be an api break, but would make the intention clearer:
#ifdef _PYTHON_C_UNSTABLE_FRAMESTACK_API
...
#endif
Member
Sorry, I didn't get a chance to look at this too closely today. My plan is to attempt to modify my fork of Greenlet tomorrow to see how well it works with this branch (and then we'll have a patch we can upstream right away, too). A few thoughts just from looking at this so far:
We can also loop in the Greenlet maintainers and get their opinion on this. @jamadden? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Skipping news, as I want to keep this as low key as possible.
We want this for greenlets, we don't want it misused by other third party code.
@brandtbucher would this cover greenlet's needs?
https://bugs.python.org/issue47215