{{ message }}
bpo-35540 dataclasses.asdict support defaultdict fields - #32056
Merged
Merged
Conversation
dataclasses.asdict breaks when there are `defaultdict`s in the dataclass attributes because it assumes `defaultdict` and `dict` are the same thing, but in reality `defaultdict` takes a default_factory as the first argument in its constructor. This change adds support for defaultdict fields.
Contributor
|
Could you add a test please? |
Contributor
Author
I just added a test for this |
MaxwellDupre
approved these changes
Jul 4, 2022
MaxwellDupre
left a comment
MaxwellDupre
left a comment
Contributor
There was a problem hiding this comment.
Tests ok on Fedora.
Ref to bugs.python.org/issue35540 is not future proof, assume will be turned off at some time.
ericvsmith
reviewed
Oct 4, 2022
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Oct 8, 2022
* main: bpo-35540 dataclasses.asdict now supports defaultdict fields (pythongh-32056) pythonGH-91052: Add C API for watching dictionaries (pythonGH-31787) bpo-38693: Use f-strings instead of str.format() within importlib (python#17058)
This was referenced Oct 10, 2022
This was referenced Oct 11, 2022
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
|
Does this merge fix the issue yet cause it still throws error in Python 3.11 |
Contributor
Author
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35540
dataclasses.asdict breaks when there are
defaultdicts in the dataclass attributes because it assumesdefaultdictanddictare the same thing, but in realitydefaultdicttakes a default_factory as the first argument in its constructor.Since
dataclasses.asdictalready supportsNamedTuples, I think its fair thatdefaultdict, which is also in the standard library, does not breakdataclasses.Test:
https://bugs.python.org/issue35540