bpo-737999 Fix codeop.compile_command docstring by abenkovskii · Pull Request #3179 · python/cpython · GitHub
Skip to content

bpo-737999 Fix codeop.compile_command docstring - #3179

Closed
abenkovskii wants to merge 4 commits into
python:masterfrom
abenkovskii:patch-1
Closed

abenkovskii wants to merge 4 commits into
python:masterfrom
abenkovskii:patch-1

Conversation

@abenkovskii

@abenkovskii abenkovskii commented Aug 22, 2017

Copy link
Copy Markdown

codeop.compile_command actually accepts symbol="exec" too

https://bugs.python.org/issue737999

codeop.compile_command actually accepts symbol="exec" too
@the-knights-who-say-ni

Copy link
Copy Markdown

@abenkovskii abenkovskii changed the title Fix codeop.compile_command docstring bpo-737999 Fix codeop.compile_command docstring Aug 22, 2017
@merwok

merwok commented Sep 20, 2017

Copy link
Copy Markdown
Member

Hello! I can’t review right now, but wanted to say you might get more attention by opening a new doc bug instead of recycling an old ticket that’s already closed.

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Éric. @abenkovskii could you please open a new issue? bpo-737999 was closed 14 years ago so it would be better to discuss your ptahc in a new issue.

Also, we don't need a NEWS entry for this.

@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner

Copy link
Copy Markdown
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@JulienPalard

Copy link
Copy Markdown
Member

@abenkovskii I agree with Berker, could you please open a new issue and remove the NEWS entry?

@csabella

Copy link
Copy Markdown
Contributor

Closing as there hasn't been any response to multiple requests for a bug report to be opened. Please feel free to re-open this PR or create a new one to address the existing comments. Thanks!

@csabella csabella closed this Nov 20, 2019
@merwok

merwok commented Nov 20, 2019

Copy link
Copy Markdown
Member

@csabella Would you mind creating a doc ticket for this?

@csabella

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants