{{ message }}
bpo-43923: Revert "bpo-40185: Refactor typing.NamedTuple (GH-19371)"#31679
Closed
juliusgeo wants to merge 3 commits into
Closed
bpo-43923: Revert "bpo-40185: Refactor typing.NamedTuple (GH-19371)"#31679juliusgeo wants to merge 3 commits into
juliusgeo wants to merge 3 commits into
Conversation
This reverts commit a2ec069.
juliusgeo
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
JelleZijlstra
requested changes
Mar 5, 2022
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
As Guido mentioned on the bug, a full revert doesn't seem like the right answer. In particular, the test_typing and frozenset changes in this PR should stay as is.
Also, if we are to move forward with this, we should:
- Add a NEWS entry
- Add a unit test testing the behavior that the bug asked for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a2ec069.
https://bugs.python.org/issue43923