{{ message }}
bpo-31354: Fixing a bug related to LTO only build - #3110
Merged
Merged
Conversation
Author
|
There is an update I am working for adding lto only compilation option. Please let me add this modification before spending any additional time in reviewing the previous commit. |
Enabling separate lto only compilation mode helps the trade-off capabilities between required compilation time and optimization results. Moreover, it enables studies of performance on different platforms. Signed-off-by: Octavian Soldea <octavian.soldea@intel.com>
octaviansoldea
force-pushed
the
lto_only
branch
from
September 5, 2017 22:47
82d62e7 to
84e1532
Compare
octaviansoldea
changed the title
vstinner
approved these changes
Sep 5, 2017
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM, but I would like to see a review by another core dev :-)
Member
gpshead
approved these changes
Sep 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Reviewers,
Following several previous communications, this pull request enables compilation of cpython with lto only optimization. While configure’s flag
--with-ltois to be used, a new make target has been added:make build_all_lto.I am looking forward to receive feedback from you.
Best regards,
Octavian
https://bugs.python.org/issue31354