bpo-30947: Update libexpat from 2.2.1 to 2.2.3 by vstinner · Pull Request #3106 · python/cpython · GitHub
Skip to content

bpo-30947: Update libexpat from 2.2.1 to 2.2.3 - #3106

Merged
vstinner merged 7 commits into
python:masterfrom
vstinner:expat223
Aug 18, 2017
Merged

vstinner merged 7 commits into
python:masterfrom
vstinner:expat223

Conversation

@vstinner

@vstinner vstinner commented Aug 16, 2017

Copy link
Copy Markdown
Member

@vstinner
vstinner requested review from gpshead and tiran August 16, 2017 14:52
@vstinner

Copy link
Copy Markdown
Member Author

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sane. i'm not reviewing the changed to expat itself, just that it appears to be a rational update. you might also consider checking in your cpython_rebuild_expat_dir.sh script that you've attached to the bpo issue.

@vstinner

Copy link
Copy Markdown
Member Author

@gpshead: "you might also consider checking in your cpython_rebuild_expat_dir.sh script that you've attached to the bpo issue."

My script is crappy: the version is hardcoded and uses the libexpat tag format, it requires a libexpat repository with an hardcoded path on my disk, etc. :-) I'm not interested to include it right now.

cc @serhiy-storchaka

@vstinner

vstinner commented Aug 17, 2017

Copy link
Copy Markdown
Member Author

@vstinner
vstinner merged commit 93d0cb5 into python:master Aug 18, 2017
@vstinner
vstinner deleted the expat223 branch August 18, 2017 21:43
vstinner added a commit that referenced this pull request Aug 18, 2017
* bpo-30947: Update libexpat from 2.2.1 to 2.2.3

* Add NEWS entry

* Add new loadlibrary.c

* expat_external.h: restore include "pyexpatns.h"

* PCbuild: add expat/loadlibrary.c

* Define XML_POOR_ENTROPY to compile expat

(cherry picked from commit 93d0cb5)
vstinner added a commit that referenced this pull request Aug 18, 2017
* bpo-30947: Update libexpat from 2.2.1 to 2.2.3

* Add NEWS entry

* Add new loadlibrary.c

* expat_external.h: restore include "pyexpatns.h"

* PCbuild: add expat/loadlibrary.c

* Define XML_POOR_ENTROPY to compile expat

Python 2.7 backport: add expat/loadlibrary.c to PC/VS9.0/ project
files (_elementtree and pyexpat).

(cherry picked from commit 93d0cb5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants