[3.10] bpo-26552: Fixed case where failing asyncio.ensure_future did not c… …lose the coroutine by kumaraditya303 · Pull Request #31003 · python/cpython · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Lib/asyncio/tasks.py
13 changes: 12 additions & 1 deletion Lib/test/test_asyncio/test_base_events.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from test.support.script_helper import assert_python_ok
from test.support import os_helper
from test.support import socket_helper

import warnings

MOCK_ANY = mock.ANY
PY34 = sys.version_info >= (3, 4)
Expand Down Expand Up @@ -801,6 +801,17 @@ def create_task(self, coro):
task._log_destroy_pending = False
coro.close()

def test_create_task_error_closes_coro(self):
async def test():
pass
loop = asyncio.new_event_loop()
loop.close()
with warnings.catch_warnings(record=True) as w:
with self.assertRaises(RuntimeError):
asyncio.ensure_future(test(), loop=loop)
self.assertEqual(len(w), 0)


def test_create_named_task_with_default_factory(self):
async def test():
pass
Expand Down