bpo-41682: skip `test_sendfile_close_peer_in_the_middle_of_receiving` in `test_asyncio` by sobolevn · Pull Request #30801 · python/cpython · GitHub
Skip to content

bpo-41682: skip test_sendfile_close_peer_in_the_middle_of_receiving in test_asyncio - #30801

Merged
vstinner merged 3 commits into
python:mainfrom
sobolevn:issue-41682
Jan 22, 2022
Merged

bpo-41682: skip test_sendfile_close_peer_in_the_middle_of_receiving in test_asyncio#30801
vstinner merged 3 commits into
python:mainfrom
sobolevn:issue-41682

Conversation

@sobolevn

@sobolevn sobolevn commented Jan 22, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

It is failing way too often:
Снимок экрана 2022-01-22 в 22 26 45

Most of the commits above failed due to this single test.
I don't know how to fix it, but at least we can decrease the noise.

https://bugs.python.org/issue41682

@sobolevn sobolevn added skip news tests Tests in the Lib/test dir labels Jan 22, 2022
@erlend-aasland

erlend-aasland commented Jan 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sobolevn sobolevn mentioned this pull request Jan 22, 2022
Merged
erlend-aasland
erlend-aasland reviewed Jan 22, 2022
View reviewed changes
Comment thread Lib/test/test_asyncio/test_sendfile.py Outdated
sobolevn
sobolevn commented Jan 22, 2022
View reviewed changes
Comment thread Lib/test/test_asyncio/test_sendfile.py Outdated
jaraco
jaraco approved these changes Jan 22, 2022
View reviewed changes
Comment thread Lib/test/test_asyncio/test_sendfile.py
@unittest.skipIf(sys.platform.startswith('sunos'),
"Doesn't work on Solaris")
@unittest.skipIf(sys.platform == "win32",
"It is flaky on Windows and needs to be fixed") # TODO: bpo-41682

@jaraco jaraco Jan 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: I'd probably include the bug number in the skip message in case that's all the viewer sees.

@vstinner vstinner Jan 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to not include it in the skip message. Otherwise, https://bugs.python.org/issue41682 will be spammed with pull requests unrelated to the change, if a CI job fails with this message. The bot which mentions PR in bpo searchs for "bpo-xxx" anyway in a PR :-(

@erlend-aasland erlend-aasland Jan 22, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch!

vstinner
vstinner approved these changes Jan 22, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would prefer to fix it, but well, since Septembre 2020, no one was available to investigate this bug, whereas this bug annoys anyone paying attention to Python CIs for 1 year and a half.

But please don't close https://bugs.python.org/issue41682 until the real issue is fixed.

@vstinner
vstinner merged commit 1ded8ed into python:main Jan 22, 2022
@miss-islington

miss-islington commented Jan 22, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jan 22, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2022
@sobolevn @miss-islington
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (pytho…
6ab7ae7 
…nGH-30801)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

bedevere-bot commented Jan 22, 2022

Copy link
Copy Markdown

GH-30811 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2022
@sobolevn @miss-islington
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (pytho…
7b40796 
…nGH-30801)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 22, 2022
@bedevere-bot

bedevere-bot commented Jan 22, 2022

Copy link
Copy Markdown

GH-30812 is a backport of this pull request to the 3.10 branch.

@sobolevn sobolevn mentioned this pull request Jan 22, 2022
Merged
@gvanrossum

gvanrossum commented Jan 23, 2022

Copy link
Copy Markdown
Member

Can someone please try to figure out what caused that test to fail, and why it got worse recently?

@vstinner

vstinner commented Jan 23, 2022

Copy link
Copy Markdown
Member

Can someone please try to figure out what caused that test to fail, and why it got worse recently?

I also noticed that the step started to fail more recently recently. Maybe a CI updated Windows. I saw an announcement that Azure Pipelines or GitHub Actions (oops, I don't recall anymore) is being upgrade incrementally to Windows Server 2022, for example.

About the bug itself, it has been reported in September 2020 and so far, no one was available to investigate the issue: https://bugs.python.org/issue41682

miss-islington added a commit that referenced this pull request Jan 23, 2022
@miss-islington @sobolevn
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801
ba932d9 
)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit that referenced this pull request Jan 23, 2022
@miss-islington @sobolevn
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801
486b4d3 
) (GH-30812)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@vstinner

vstinner commented Jan 23, 2022

Copy link
Copy Markdown
Member

@arhadthedev arhadthedev mentioned this pull request Jan 24, 2022
Merged
@erlend-aasland erlend-aasland mentioned this pull request Jan 24, 2022
Merged
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @sobolevn @hello-adam
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (pytho…
f65180b 
…nGH-30801)

(cherry picked from commit 1ded8ed)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@aeros aeros mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@vstinner vstinner vstinner approved these changes
@jaraco jaraco jaraco approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sobolevn @erlend-aasland @miss-islington @bedevere-bot @gvanrossum @vstinner @jaraco