{{ message }}
gh-89886: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE#30029
Closed
erlend-aasland wants to merge 2 commits intopython:mainfrom
Closed
gh-89886: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE#30029erlend-aasland wants to merge 2 commits intopython:mainfrom
erlend-aasland wants to merge 2 commits intopython:mainfrom
Conversation
AC_CHECK_TYPE is deprecated. Removed the __uint128_t check, as it is unused.
erlend-aasland
added
skip news
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
|
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
suggested changes
Feb 21, 2022
Contributor
MaxwellDupre
left a comment
MaxwellDupre
left a comment
There was a problem hiding this comment.
Python executable created and tests look ok, but I see in config.log:
configure:19906: checking for socklen_t configure:19906: gcc -c conftest.c >&5 configure:19906: $? = 0 configure:19906: gcc -c conftest.c >&5 conftest.c: In function 'main': conftest.c:432:24: error: expected expression before ')' token 432 | if (sizeof ((socklen_t))) |
This looks like an issue.
erlend-aasland
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AC_CHECK_TYPE is deprecated.
Removed the __uint128_t check, as the define it produced is unused.
https://bugs.python.org/issue45723