Allow up to a 0.01% drop in coverage by zware · Pull Request #30 · python/cpython · GitHub
Skip to content

Allow up to a 0.01% drop in coverage#30

Merged
ambv merged 1 commit intopython:masterfrom
zware:more_lenient_codecov
Feb 13, 2017
Merged

Allow up to a 0.01% drop in coverage#30
ambv merged 1 commit intopython:masterfrom
zware:more_lenient_codecov

Conversation

@zware
Copy link
Copy Markdown
Member

@zware zware commented Feb 11, 2017

I'm not sure that this is correct, but we'll see what codecov thinks. It does pass the validator, but I couldn't get the validator to fail at all with well-formed YAML...

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 11, 2017

@nedbat
Copy link
Copy Markdown
Member

nedbat commented Feb 11, 2017

I'm curious what the reasoning for this is?

@terryjreedy
Copy link
Copy Markdown
Member

Several pull request threads, such as this one, have gotten noisy but irrelevant 'coverage decreased by .01 %' warnings. I am puzzled that this patch to the .yml driver should change code coverage at all. If the change shrinks the message somehow, I am in favor of it.

@zware
Copy link
Copy Markdown
Member Author

zware commented Feb 12, 2017

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the coverage complaining on multiple PR whereas the change couldn't have any effect of the coverage, so I'm +1 on this change ;-)

@ambv ambv merged commit 649a7ca into python:master Feb 13, 2017
@zware zware deleted the more_lenient_codecov branch February 14, 2017 16:11
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
A first pass on the documentation, including usage and migration guides.  API docs will be done in a follow up PR.
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
* Replace pep517.build with build

Resolves python#30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
* Use `extend-ignore` in flake8 config

This option allows to add extra ignored rules to the default list
instead of replacing it.

The default exclusions are: E121, E123, E126, E226, E24, E704,
W503 and W504.

Fixes python#28.

Refs:
* https://github.com/pypa/setuptools/pull/2486/files#r541943356
* https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore
*
https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore

* Enable complexity limit. Fixes jaraco/skeleton#34.

* Replace pep517.build with build (python#37)

* Replace pep517.build with build

Resolves python#30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

* Use license_files instead of license_file in meta (python#35)

Singular `license_file` is deprecated since wheel v0.32.0.

Refs:
* https://wheel.readthedocs.io/en/stable/news.html
* https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants