{{ message }}
bpo-45459: Add Py_buffer to limited API - #29991
Merged
Merged
Conversation
tiran
force-pushed
the
bpo-45459-bufapi-struct
branch
2 times, most recently
from
January 13, 2022 10:40
a990f73 to
200d441
Compare
tiran
force-pushed
the
bpo-45459-bufapi-struct
branch
2 times, most recently
from
January 24, 2022 08:00
1c41c9d to
ef19458
Compare
Member
Author
|
@encukou could you take a look, please? |
Member
|
I'll get to it this week. |
encukou
reviewed
Feb 2, 2022
Member
There was a problem hiding this comment.
Can we leave out the bufferinfo tag? Anonymous structs are well-supported nowadays, and only Py_buffer should be public.
tiran
force-pushed
the
bpo-45459-bufapi-struct
branch
from
February 2, 2022 13:21
ef19458 to
6119c2b
Compare
encukou
approved these changes
Feb 2, 2022
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
Looks good, let's get it in! Thanks!
|
This change broke our project build because when cpython/object.h is including buffer.h it is forcing it to resolve along the search path, and the compiler is hitting the buffer.h in our project rather than the one in the Python include directory. Should it not be using a relative include, ie. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py_bufferstructPyBuffer_*()API functionsPyBUF_*constantsPy_bf_getbufferandPy_bf_releasebuffertype slotsPyMemoryView_FromBuffer()APImake regen-limited-abiPyPickleBuffer*()API ???https://bugs.python.org/issue45459
Automerge-Triggered-By: GH:encukou