{{ message }}
bpo-45691: Make array of small ints static to fix use-after-free error. - #29366
Merged
Merged
Conversation
ericsnowcurrently
approved these changes
Nov 2, 2021
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
Member
There was a problem hiding this comment.
Note the small ints have been in PyInterpreterState for a while. We didn't get use-after-free until gh-29274. So perhaps we could just revert that one? The general underlying problem in bpo-45691 is one we'll have to fix regardless, so there's no need to go all the way back to using a static global.
Otherwise this looks fine.
(I'm approving assuming that you'll take my feedback into consideration before merging and discuss if you disagree.)
Member
Author
Member
ericsnowcurrently
approved these changes
Nov 3, 2021
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
Member
There was a problem hiding this comment.
I'm good with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45691