Handle error when PyUnicode_GetLength returns a negative value. by corona10 · Pull Request #28859 · python/cpython · GitHub
Skip to content

Handle error when PyUnicode_GetLength returns a negative value.#28859

Merged
corona10 merged 1 commit into
python:mainfrom
corona10:imortdl-fix
Oct 11, 2021
Merged

Handle error when PyUnicode_GetLength returns a negative value.#28859
corona10 merged 1 commit into
python:mainfrom
corona10:imortdl-fix

Conversation

@corona10

@corona10 corona10 commented Oct 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

motivation: #28705 (comment)

vstinner
vstinner approved these changes Oct 11, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10 corona10 merged commit 560a79f into python:main Oct 11, 2021
@miss-islington

miss-islington commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

@corona10 corona10 deleted the imortdl-fix branch October 11, 2021 11:08
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2021
@corona10 @miss-islington
Handle error when PyUnicode_GetLength returns a negative value. (pyth…
63064ef 
…onGH-28859)

(cherry picked from commit 560a79f)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot

bedevere-bot commented Oct 11, 2021

Copy link
Copy Markdown

GH-28876 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 11, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2021
@corona10 @miss-islington
Handle error when PyUnicode_GetLength returns a negative value. (pyth…
227fc48 
…onGH-28859)

(cherry picked from commit 560a79f)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot

bedevere-bot commented Oct 11, 2021

Copy link
Copy Markdown

miss-islington added a commit that referenced this pull request Oct 11, 2021
@miss-islington @corona10
Handle error when PyUnicode_GetLength returns a negative value. (GH-2…
56825b6 
…8859)

(cherry picked from commit 560a79f)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
miss-islington added a commit that referenced this pull request Oct 11, 2021
@miss-islington @corona10
Handle error when PyUnicode_GetLength returns a negative value. (GH-2…
7d1ae89 
…8859)

(cherry picked from commit 560a79f)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@corona10 @miss-islington @bedevere-bot @vstinner @serhiy-storchaka @the-knights-who-say-ni