{{ message }}
[3.10] bpo-43760: Ensure that older Cython generated code compiles under 3.10. - #28474
Closed
markshannon wants to merge 2 commits into
Closed
markshannon wants to merge 2 commits into
markshannon wants to merge 2 commits into
Conversation
…imize breakage in Cython generated modules.
Member
Author
Member
Because code can dereference the pointer and if you know the full definition the compiler needs the offsets to optimize member access. |
Member
For instance, this is this particular case: |
Member
|
Don't worry too much, as the fields are not public we can just regenerate the ABI. The check is there so you don't change it unadvertedly. |
Member
|
Seems I cannot push to the fork you are using. Can you make sure the checkbox allowing pushes from maintaners is checked on this PR (on the right of the PR page, at the bottom IIRC) |
Member
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Not sure what sort of NEWS entry this needs, if any.
https://bugs.python.org/issue43760