Make asyncio main importable by fixing references to global vars by asrp · Pull Request #28184 · python/cpython · GitHub
Skip to content

Make asyncio main importable by fixing references to global vars - #28184

Closed
asrp wants to merge 1 commit into
python:mainfrom
asrp:main
Closed

asrp wants to merge 1 commit into
python:mainfrom
asrp:main

Conversation

@asrp

@asrp asrp commented Sep 6, 2021

Copy link
Copy Markdown

RIght now, importing this module makes classes in it unusable as the name == '__main__' block isn't run. This is a small fix for that.

The change is small but please let me know if this is issue number worthy.

@asrp
asrp requested review from 1st1 and asvetlov as code owners September 6, 2021 16:39
@the-knights-who-say-ni

Copy link
Copy Markdown

@nanjekyejoannah nanjekyejoannah changed the title (No issue number) Make asyncio main importable by fixing references to global vars Make asyncio main importable by fixing references to global vars Sep 6, 2021
@serhiy-storchaka

Copy link
Copy Markdown
Member

You should not import from ayncio.__main__, it is not designed for importing.

If you have a use case please open an issue on the bug tracker for discussion. Only trivial PRs do not require corresponding issue.

@github-actions

github-actions Bot commented Oct 8, 2021

Copy link
Copy Markdown

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants