bpo-44792: Improve syntax errors for if expressions by miguendes · Pull Request #27506 · python/cpython · GitHub
Skip to content

bpo-44792: Improve syntax errors for if expressions - #27506

Merged
pablogsal merged 1 commit into
python:mainfrom
miguendes:bpo-44792
Aug 2, 2021
Merged

bpo-44792: Improve syntax errors for if expressions#27506
pablogsal merged 1 commit into
python:mainfrom
miguendes:bpo-44792

Conversation

@miguendes

@miguendes miguendes commented Jul 31, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@miguendes miguendes changed the title Improve syntax errors for if expressions bpo-44792: Improve syntax errors for if expressions Jul 31, 2021
pablogsal
pablogsal requested changes Jul 31, 2021
View reviewed changes
Comment thread Grammar/python.gram Outdated
@bedevere-bot

bedevere-bot commented Jul 31, 2021

Copy link
Copy Markdown

@miguendes
miguendes force-pushed the bpo-44792 branch 2 times, most recently from 6106656 to cfdf3c4 Compare July 31, 2021 14:53
@miguendes
miguendes requested a review from pablogsal July 31, 2021 14:53
@pablogsal

pablogsal commented Jul 31, 2021

Copy link
Copy Markdown
Member

You need to run make regen-pegen to regenerate the parser files as well @miguendes

@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Jul 31, 2021
@miguendes

miguendes commented Jul 31, 2021

Copy link
Copy Markdown
Contributor Author

You need to run make regen-pegen to regenerate the parser files as well @miguendes

Thanks @pablogsal It works now, but there's an asyncio and concurrent.futures tests failing on Windows PR Tests win64. Could they be related?

@pablogsal

pablogsal commented Jul 31, 2021

Copy link
Copy Markdown
Member

You need to run make regen-pegen to regenerate the parser files as well @miguendes

Thanks @pablogsal It works now, but there's an asyncio and concurrent.futures tests failing on Windows PR Tests win64. Could they be related?

Unless is a syntax error is unlikely. I will investigate...

@pablogsal pablogsal closed this Jul 31, 2021
@pablogsal pablogsal reopened this Jul 31, 2021
@pablogsal
pablogsal merged commit 28b6dc9 into python:main Aug 2, 2021
@miss-islington

miss-islington commented Aug 2, 2021

Copy link
Copy Markdown
Contributor

Thanks @miguendes for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 2, 2021
@bedevere-bot

bedevere-bot commented Aug 2, 2021

Copy link
Copy Markdown

GH-27565 is a backport of this pull request to the 3.10 branch.

@pablogsal

pablogsal commented Aug 2, 2021

Copy link
Copy Markdown
Member

pablogsal pushed a commit to miss-islington/cpython that referenced this pull request Aug 2, 2021
@miguendes @pablogsal
bpo-44792: Improve syntax errors for if expressions (pythonGH-27506)
8dacb9e 
(cherry picked from commit 28b6dc9)

Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Aug 2, 2021
@miss-islington @miguendes
bpo-44792: Improve syntax errors for if expressions (GH-27506) (GH-27565
5671762 
)

(cherry picked from commit 28b6dc9)

Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miguendes @bedevere-bot @pablogsal @miss-islington @the-knights-who-say-ni