{{ message }}
bpo-42378: fixed log truncation on logging shutdown - #27310
Merged
miss-islington merged 7 commits intoJul 25, 2021
Merged
Conversation
akulakov
changed the title
vsajip
requested changes
Jul 25, 2021
vsajip
left a comment
vsajip
left a comment
Member
There was a problem hiding this comment.
Generally looks OK, but I would suggest the following changes:
_closed = Trueis done inHandler.close(), and so there is a reliance thatFileHandler.close()will call the superclass'close(). Of course it does, and there is a comment there about bpo-19523 and avoiding a handler leak, but I would add under that something like# See also bpo-42378: we also rely on # self._closed being set to True there- As you've added
next_rec()toBaseFileTest, it can be removed fromRotatingFileHandlerTest, which inherits fromBaseFileTest. - And, of course, add the documentation update and NEWS entry, as you've mentioned on the issue,
Thanks!
Contributor
Author
|
@vsajip Thanks for the review! |
vsajip
requested changes
Jul 25, 2021
vsajip
left a comment
vsajip
left a comment
Member
There was a problem hiding this comment.
Just minor changes suggested to the documentation part. Thanks!
| Outputs the record to the file. | ||
|
|
||
| Note that if the file was closed due to logging shutdown at exit and file | ||
| mode is 'w', record will not be emitted (see :issue:`42378`). |
Member
There was a problem hiding this comment.
I would change "file mode" to "the file mode" and "record" to "the record".
Contributor
Author
|
@vsajip fixed the docs per comment.. |
vsajip
approved these changes
Jul 25, 2021
Contributor
|
@akulakov: Status check is done, and it's a success ✅ . |
Contributor
Author
|
thanks @vsajip ! |
Contributor
|
Thanks @akulakov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 7, 2022
Automerge-Triggered-By: GH:vsajip (cherry picked from commit 96cf5a6) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
vsajip
pushed a commit
that referenced
this pull request
Jan 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue42378
Automerge-Triggered-By: GH:vsajip