{{ message }}
bpo-41255: handle argparse errors with exit_on_error=False consistently - #27295
Closed
joshmeranda wants to merge 4 commits into
Closed
bpo-41255: handle argparse errors with exit_on_error=False consistently#27295joshmeranda wants to merge 4 commits into
joshmeranda wants to merge 4 commits into
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
approved these changes
Mar 14, 2022
MaxwellDupre
left a comment
MaxwellDupre
left a comment
Contributor
There was a problem hiding this comment.
Works for me:
Ran 1658 tests in 2.516s
OK
Simple bug mentioned case too!
Nice work
Member
|
Trigger CLA. A |
AA-Turner
added
type-bug
|
This PR is stale because it has been open for 30 days with no activity. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-41255
When unknown arguments are passed to
parse_argsor required arguments not passed to eitherparse_argsorparse_known_argsargpase exits despiteexit_on_error=False. This is not very intuitive, instead any error parsing arguments should result in anArgumentErrorwhich can be handled by the user.https://bugs.python.org/issue41255