{{ message }}
bpo-44631: Make the repr() of the _Environ class more readable. - #27128
Merged
Merged
Conversation
* Refactored the repr() of the _Environ class * Update os.py (_Environ) * Update test_os.py (EnvironTests)
vedgar
suggested changes
Jul 14, 2021
ambv
requested changes
Jul 15, 2021
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Unified item formatting in the formatted_items variable Co-authored-by: Łukasz Langa <lukasz@langa.pl>
* Update test_os.py
* Removed mention of test test___repr__
Contributor
|
Please sign the CLA, @Leonardofreua, and we're good to go. |
Contributor
Author
|
@ambv I've already signed up. I'm waiting one business day for the subscription to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the repr() of the _Environ class
Update os.py (_Environ)
Update test_os.py (EnvironTests)
https://bugs.python.org/issue44631