bpo-44389: Fix typo in ssl deprecation warning message by j178 · Pull Request #26754 · python/cpython · GitHub
Skip to content

bpo-44389: Fix typo in ssl deprecation warning message - #26754

Merged
miss-islington merged 2 commits into
python:mainfrom
j178:main
Jun 17, 2021
Merged

bpo-44389: Fix typo in ssl deprecation warning message#26754
miss-islington merged 2 commits into
python:mainfrom
j178:main

Conversation

@j178

@j178 j178 commented Jun 16, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

ssl.SSL_NO_TLS should be ssl.OP_NO_TLS.

https://bugs.python.org/issue44389

Automerge-Triggered-By: GH:tiran

@the-knights-who-say-ni

the-knights-who-say-ni commented Jun 16, 2021

Copy link
Copy Markdown

@tiran tiran changed the title Fix typo in ssl deprecation warning message bpo-44389: Fix typo in ssl deprecation warning message Jun 16, 2021
tiran
tiran requested changes Jun 16, 2021
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update test_openssl111_deprecations test case and sign the contribute agreement.

@bedevere-bot

bedevere-bot commented Jun 16, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@j178

j178 commented Jun 17, 2021

Copy link
Copy Markdown
Contributor Author

Updated test

@miss-islington
miss-islington merged commit c544393 into python:main Jun 17, 2021
@miss-islington

miss-islington commented Jun 17, 2021

Copy link
Copy Markdown
Contributor

Thanks @j178 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 17, 2021
@j178 @miss-islington
bpo-44389: Fix typo in ssl deprecation warning message (pythonGH-26754)
5253add 
`ssl.SSL_NO_TLS` should be `ssl.OP_NO_TLS`.
(cherry picked from commit c544393)

Co-authored-by: Joe <nigelchiang@outlook.com>
@bedevere-bot

bedevere-bot commented Jun 17, 2021

Copy link
Copy Markdown

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 17, 2021
miss-islington added a commit that referenced this pull request Jun 17, 2021
@miss-islington @j178
bpo-44389: Fix typo in ssl deprecation warning message (GH-26754)
08f2b9d 
`ssl.SSL_NO_TLS` should be `ssl.OP_NO_TLS`.
(cherry picked from commit c544393)

Co-authored-by: Joe <nigelchiang@outlook.com>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
@j178 @jdevries3133
bpo-44389: Fix typo in ssl deprecation warning message (pythonGH-26754)
439482a 
`ssl.SSL_NO_TLS` should be `ssl.OP_NO_TLS`.
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@j178 @the-knights-who-say-ni @bedevere-bot @miss-islington @tiran