bpo-44133: Export Py_FrozenMain() symbol by vstinner · Pull Request #26130 · python/cpython · GitHub
Skip to content

bpo-44133: Export Py_FrozenMain() symbol - #26130

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:export_frozenmain
Closed

bpo-44133: Export Py_FrozenMain() symbol#26130
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:export_frozenmain

Conversation

@vstinner

@vstinner vstinner commented May 14, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The Python binary now builds the libpython static library using
"-Wl,--whole-archive" linker option to export all symbols exported by
object files. Previously, the "Py_FrozenMain" symbol was not
exported.

https://bugs.python.org/issue44133

@vstinner
bpo-44133: Export Py_FrozenMain() symbol
09e30f3 
The Python binary now builds the libpython static library using
"-Wl,--whole-archive" linker option to export all symbols exported by
object files. Previously, the "Py_FrozenMain" symbol was not
exported.
pablogsal
pablogsal approved these changes May 14, 2021
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs backport to 3.10 at the very least, no?

shreyanavigyan
shreyanavigyan reviewed May 14, 2021
View reviewed changes
Comment thread Makefile.pre.in
@vstinner

vstinner commented May 14, 2021

Copy link
Copy Markdown
Member Author

@pablogsal

pablogsal commented May 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

I'm not sure that it makes sense to treat a python executable binary as a library

It absolutely does, if not, how can C extensions get access to the C-API?

corona10
corona10 reviewed May 15, 2021
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang does not support --whole-archive can we use -all_load on macOS for that purpose?

@github-actions

github-actions Bot commented Jun 15, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 15, 2021
@vstinner

vstinner commented Sep 21, 2021

Copy link
Copy Markdown
Member Author

-Wl,--whole-archive is not as portable as as expected. IMO another approach should be taken. Don't use the static library to link the "python" binary, "simply" pass the whole list of all object files.

@vstinner vstinner closed this Sep 21, 2021
@vstinner
vstinner deleted the export_frozenmain branch September 21, 2021 22:10
@shihai1991

shihai1991 commented Dec 1, 2021

Copy link
Copy Markdown
Member

@vstinner vstinner mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 left review comments
@pablogsal pablogsal pablogsal approved these changes
+2 more reviewers
@serge-sans-paille serge-sans-paille serge-sans-paille left review comments
@shreyanavigyan shreyanavigyan shreyanavigyan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting merge stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vstinner @pablogsal @shihai1991 @serge-sans-paille @corona10 @shreyanavigyan @the-knights-who-say-ni @bedevere-bot