iframe-proxy

vstinner · 2021-04-28T11:23:46Z

Fix test_logging.test_namer_rotator_inheritance() on Windows: use
os.replace() rather than os.rename().

https://bugs.python.org/issue43961

Fix test_logging.test_namer_rotator_inheritance() on Windows: use os.replace() rather than os.rename().

vstinner · 2021-04-28T11:25:13Z

I confirm that my PR fix https://bugs.python.org/issue43961 warning, I tested my fix manually on Windows.

Without this PR:

vstinner@DESKTOP-DK7VBIL C:\vstinner\python\master>python -m test test_logging -m test_namer_rotator_inheritance
Running Debug|x64 interpreter...
0:00:00 Run tests sequentially
0:00:00 [1/1] test_logging
--- Logging error ---
Traceback (most recent call last):
  File "C:\vstinner\python\master\lib\logging\handlers.py", line 74, in emit
    self.doRollover()
  File "C:\vstinner\python\master\lib\logging\handlers.py", line 179, in doRollover
    self.rotate(self.baseFilename, dfn)
  File "C:\vstinner\python\master\lib\logging\handlers.py", line 117, in rotate
    self.rotator(source, dest)
  File "C:\vstinner\python\master\lib\test\test_logging.py", line 5222, in rotator
    os.rename(source, dest + ".rotated")
FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'C:\\Users\\vstinner\\AppData\\Local\\Temp\\test
_logging-2-dsj_zrxi.log' -> 'C:\\Users\\vstinner\\AppData\\Local\\Temp\\test_logging-2-dsj_zrxi.log.1.test.rotated'
Call stack:
  File "C:\vstinner\python\master\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\vstinner\python\master\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\vstinner\python\master\lib\test\__main__.py", line 2, in <module>
    main()
  File "C:\vstinner\python\master\lib\test\libregrtest\main.py", line 719, in main
    Regrtest().main(tests=tests, **kwargs)
  File "C:\vstinner\python\master\lib\test\libregrtest\main.py", line 641, in main
    self._main(tests, kwargs)
  File "C:\vstinner\python\master\lib\test\libregrtest\main.py", line 694, in _main
    self.run_tests()
  File "C:\vstinner\python\master\lib\test\libregrtest\main.py", line 521, in run_tests
    self.run_tests_sequential()
  File "C:\vstinner\python\master\lib\test\libregrtest\main.py", line 423, in run_tests_sequential
    result = runtest(self.ns, test_name)
  File "C:\vstinner\python\master\lib\test\libregrtest\runtest.py", line 194, in runtest
    return _runtest(ns, test_name)
  File "C:\vstinner\python\master\lib\test\libregrtest\runtest.py", line 154, in _runtest
    result = _runtest_inner(ns, test_name,
  File "C:\vstinner\python\master\lib\test\libregrtest\runtest.py", line 282, in _runtest_inner
    refleak = _runtest_inner2(ns, test_name)
  File "C:\vstinner\python\master\lib\test\libregrtest\runtest.py", line 246, in _runtest_inner2
    test_runner()
  File "C:\vstinner\python\master\lib\test\support\__init__.py", line 682, in inner
    return func(*args, **kwds)
  File "C:\vstinner\python\master\lib\test\test_logging.py", line 5503, in test_main
    support.run_unittest(*tests)
  File "C:\vstinner\python\master\lib\test\support\__init__.py", line 1082, in run_unittest
    _run_suite(suite)
  File "C:\vstinner\python\master\lib\test\support\__init__.py", line 959, in _run_suite
    result = runner.run(suite)
  File "C:\vstinner\python\master\lib\test\support\testresult.py", line 169, in run
    test(self.result)
  File "C:\vstinner\python\master\lib\unittest\suite.py", line 84, in __call__
    return self.run(*args, **kwds)
  File "C:\vstinner\python\master\lib\unittest\suite.py", line 122, in run
    test(result)
  File "C:\vstinner\python\master\lib\unittest\suite.py", line 84, in __call__
    return self.run(*args, **kwds)
  File "C:\vstinner\python\master\lib\unittest\suite.py", line 122, in run
    test(result)
  File "C:\vstinner\python\master\lib\unittest\case.py", line 652, in __call__
    return self.run(*args, **kwds)
  File "C:\vstinner\python\master\lib\unittest\case.py", line 592, in run
    self._callTestMethod(testMethod)
  File "C:\vstinner\python\master\lib\unittest\case.py", line 549, in _callTestMethod
    method()
  File "C:\vstinner\python\master\lib\test\test_logging.py", line 5229, in test_namer_rotator_inheritance
    rh.emit(self.next_rec())
Message: '2'
Arguments: None

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1.9 sec
Tests result: SUCCESS

With this PR:

vstinner@DESKTOP-DK7VBIL C:\vstinner\python\master>python -m test test_logging -m test_namer_rotator_inheritance
Running Debug|x64 interpreter...
0:00:00 Run tests sequentially
0:00:00 [1/1] test_logging

== Tests result: SUCCESS ==

1 test OK.

Total duration: 767 ms
Tests result: SUCCESS

vstinner · 2021-04-28T11:52:48Z

On Windows x64, test_multiprocessing_timeout() of test_regrtest fails with a timeout (20 min).

Tests result: FAILURE then SUCCESS
Error: Process completed with exit code 1.

Not sure why it returned exit code 1 even if it's a success, but I re-run all jobs.

miss-islington · 2021-04-28T13:47:55Z

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

…H-25684) Fix test_logging.test_namer_rotator_inheritance() on Windows: use os.replace() rather than os.rename(). (cherry picked from commit fe52eb6) Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-bot · 2021-04-28T13:48:06Z

… (GH-25688) Fix test_logging.test_namer_rotator_inheritance() on Windows: use os.replace() rather than os.rename(). (cherry picked from commit fe52eb6) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Victor Stinner <vstinner@python.org>

bpo-43961: Fix test_logging.test_namer_rotator_inheritance()

8bfcd5d

Fix test_logging.test_namer_rotator_inheritance() on Windows: use os.replace() rather than os.rename().

vstinner requested a review from vsajip as a code owner April 28, 2021 11:23

the-knights-who-say-ni added the CLA signed label Apr 28, 2021

bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Apr 28, 2021

vstinner merged commit fe52eb6 into python:master Apr 28, 2021

bedevere-bot removed the awaiting core review label Apr 28, 2021

vstinner deleted the test_logging_replace branch April 28, 2021 13:47

vstinner added the needs backport to 3.9 label Apr 28, 2021

bedevere-bot removed the needs backport to 3.9 label Apr 28, 2021

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

Uh oh!

bpo-43961: Fix test_logging.test_namer_rotator_inheritance() - #25684

bpo-43961: Fix test_logging.test_namer_rotator_inheritance()#25684
vstinner merged 1 commit into
python:masterfrom
vstinner:test_logging_replace

vstinner commented Apr 28, 2021 •

edited by bedevere-bot

Loading

Uh oh!

vstinner commented Apr 28, 2021

Uh oh!

vstinner commented Apr 28, 2021

Uh oh!

miss-islington commented Apr 28, 2021

Uh oh!

bedevere-bot commented Apr 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

vstinner commented Apr 28, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Apr 28, 2021

Uh oh!

vstinner commented Apr 28, 2021

Uh oh!

miss-islington commented Apr 28, 2021

Uh oh!

bedevere-bot commented Apr 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vstinner commented Apr 28, 2021 •

edited by bedevere-bot

Loading