{{ message }}
bpo-38530: Require 50% similarity in NameError suggestions - #25584
Merged
Merged
Conversation
Member
Member
|
Yeah, could you remove the NEWS entry, @sweeneyde? Otherwise, LGTM |
pablogsal
reviewed
Apr 25, 2021
This reverts commit bd1ad7a.
sweeneyde
force-pushed
the
bad_small_suggestions
branch
from
April 25, 2021 03:58
efba22a to
c88fd85
Compare
Member
Author
|
A thought: MAX_DISTANCE could be made larger if this change is made. |
Member
Indeed, do you have some bandwidth to do some investigation on this? I am referring to what could be a sensible value once we merge this PR. |
Member
Author
I can look at some other compilers/interpreters/editors/document processors within the next few days. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38530