{{ message }}
bpo-43788: Generate version specific _ssl_data.h - #25300
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Christian Heimes <christian@python.org>
benjaminp
approved these changes
Apr 9, 2021
benjaminp
left a comment
benjaminp
left a comment
Contributor
There was a problem hiding this comment.
this is definitely a lot better than parsing the headers
Member
Author
Contributor
|
@tiran: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Contributor
|
Sorry, @tiran, I could not cleanly backport this to |
Contributor
|
Sorry @tiran, I had trouble checking out the |
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Apr 9, 2021
Signed-off-by: Christian Heimes <christian@python.org> Automerge-Triggered-By: GH:tiran. (cherry picked from commit 150af75) Co-authored-by: Christian Heimes <christian@python.org>
|
GH-25310 is a backport of this pull request to the 3.9 branch. |
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Apr 9, 2021
Signed-off-by: Christian Heimes <christian@python.org> Automerge-Triggered-By: GH:tiran. (cherry picked from commit 150af75) Co-authored-by: Christian Heimes <christian@python.org>
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Jul 1, 2022
davidben
added a commit
to davidben/cpython
that referenced
this pull request
Dec 6, 2022
…codes Prior to python#25300, the make_ssl_data.py script used various tables, exposed in _ssl, to update the error list. After that PR, this is no longer used. Moreover, the err_names_to_codes map isn't used at all. Clean those up. This gets them out of the way if, in the future, OpenSSL provides an API to do what the code here is doing directly. (openssl/openssl#19848)
davidben
added a commit
to davidben/cpython
that referenced
this pull request
Dec 6, 2022
…codes Prior to python#25300, the make_ssl_data.py script used various tables, exposed in _ssl, to update the error list. After that PR, this is no longer used. Moreover, the err_names_to_codes map isn't used at all. Clean those up. This gets them out of the way if, in the future, OpenSSL provides an API to do what the code here is doing directly. (openssl/openssl#19848)
zooba
pushed a commit
that referenced
this pull request
Apr 3, 2023
…H-100063) Prior to #25300, the make_ssl_data.py script used various tables, exposed in _ssl, to update the error list. After that PR, this is no longer used. Moreover, the err_names_to_codes map isn't used at all. Clean those up. This gets them out of the way if, in the future, OpenSSL provides an API to do what the code here is doing directly. (openssl/openssl#19848)
gaogaotiantian
pushed a commit
to gaogaotiantian/cpython
that referenced
this pull request
Apr 8, 2023
…codes (pythonGH-100063) Prior to python#25300, the make_ssl_data.py script used various tables, exposed in _ssl, to update the error list. After that PR, this is no longer used. Moreover, the err_names_to_codes map isn't used at all. Clean those up. This gets them out of the way if, in the future, OpenSSL provides an API to do what the code here is doing directly. (openssl/openssl#19848)
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
…codes (pythonGH-100063) Prior to python#25300, the make_ssl_data.py script used various tables, exposed in _ssl, to update the error list. After that PR, this is no longer used. Moreover, the err_names_to_codes map isn't used at all. Clean those up. This gets them out of the way if, in the future, OpenSSL provides an API to do what the code here is doing directly. (openssl/openssl#19848)
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Mar 11, 2024
…thonGH-25311) (cherry picked from commit 150af75) Co-authored-by: Christian Heimes <christian@python.org>
mcepl
pushed a commit
to openSUSE-Python/cpython
that referenced
this pull request
Apr 2, 2024
…thonGH-25311) (cherry picked from commit 150af75) Co-authored-by: Christian Heimes <christian@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue43788
Automerge-Triggered-By: GH:tiran