bpo-43244: GitHub Action builds Python in debug mode on Windows by vstinner · Pull Request #24914 · python/cpython · GitHub
Skip to content

bpo-43244: GitHub Action builds Python in debug mode on Windows#24914

Closed
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:gha_win_debug
Closed

bpo-43244: GitHub Action builds Python in debug mode on Windows#24914
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:gha_win_debug

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Mar 18, 2021

The debug mode catchs more bugs but is slower.

https://bugs.python.org/issue43244

@vstinner
Copy link
Copy Markdown
Member Author

The debug mode catchs more bugs but is slower.
@vstinner
Copy link
Copy Markdown
Member Author

Oh, test_peg_generator failed. I rebased my PR on top of my commit 57d0a87 fix.

test_locale also fails, I don't know why and I don't see why it only fails in debug mode:

ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_locale.py", line 567, in test_getsetlocale_issue1813
    locale.setlocale(locale.LC_CTYPE, loc)
  File "D:\a\cpython\cpython\lib\locale.py", line 610, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

@vstinner
Copy link
Copy Markdown
Member Author

The job still fails with:

ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_locale.py", line 567, in test_getsetlocale_issue1813
    locale.setlocale(locale.LC_CTYPE, loc)
  File "D:\a\cpython\cpython\lib\locale.py", line 610, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

With test_locale re-run in verbose mode, "the total tests duration is 19 min 41 sec.

@vstinner
Copy link
Copy Markdown
Member Author

Oh, test_locale failure seems to be known since 2019: https://bugs.python.org/issue37945

@vstinner
Copy link
Copy Markdown
Member Author

@vstinner vstinner closed this Mar 18, 2021
@vstinner vstinner deleted the gha_win_debug branch March 18, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants