{{ message }}
bpo-40170: Always define PyExceptionClass_Name as a function - #24553
Merged
vstinner merged 2 commits intoFeb 17, 2021
Merged
Conversation
Contributor
Author
Member
Right, these changes impact the C API. If these changes were made after the latest Python 3.10 release, you can move the NEWS entries in a new PR. Otherwise, we can leave them, it's not a big deal. |
Member
|
Merged, thanks. The function is only used to display errors, so I don't think that we need to micro-optimize the code (add an internal static inline function, for example), it's not "hot code". I consider that error handling is "cold code". |
Contributor
Author
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…nGH-24553) Remove macro variant of PyExceptionClass_Name().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the macro variant, as it accessed
PyTypeObject.tp_namedirectly.https://bugs.python.org/issue40170