{{ message }}
Conversation
tomKPZ
force-pushed
the
fix-issue-42917
branch
from
January 15, 2021 06:14
6c641a1 to
496c869
Compare
Member
|
It looks like this PR includes a fix for block handling for Could you put that fix in a separate PR? Thanks. |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
@tomKPZ any progress on this? |
github-actions
Bot
removed
the
stale
Contributor
Author
|
Sorry for the late response. ASYNC_COMPREHENSION_GENERATOR PR uploaded: #24865 Are there any changes I need to make on this PR (besides rebasing)? It would be nice to know if it will be merged or not. |
This removes the hardcoded block stack size of 20 since typical functions have far less than 20 nested blocks. When running an empty program, 256 frame objects get created with an old average size of 420.281 bytes. This change reduces the average size to less than half: 197.000 bytes on x86_64. The goal is not necessarily to reduce memory usage, but to make it more likely for stack frames to stay in L1 cache. In addition, the maximum of 20 blocks is removed. This should make it easier to write code generators that produce deeply nested code.
tiran
removed their request for review
April 17, 2021 21:16
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the hardcoded block stack size of 20 since typical
functions have far less than 20 nested blocks. When running an empty
program, 256 frame objects get created with an old average size of
420.281 bytes. This change reduces the average size to less than
half: 197.000 bytes on x86_64. The goal is not necessarily to reduce
memory usage, but to make it more likely for stack frames to stay in
L1 cache.
In addition, the maximum of 20 blocks is removed. This should make it
easier to write code generators that produce deeply nested code.
https://bugs.python.org/issue42917