bpo-30703: More reentrant signal handler

Modify the signal handler to not call Py_AddPendingCall() function since this function uses a lock and a list, and so is unlikely to be reentrant. Add a new _PyEval_SignalReceived() function which only writes into an atomic variable and so is reentrant.
python · vstinner · Jun 26, 2017 · Jun 26, 2017 · fb11664cb710841df0fe2ff06db745f9566b6010 · pitrou
commit fb11664cb710841df0fe2ff06db745f9566b6010
diff --git a/Include/ceval.h b/Include/ceval.h
@@ -54,6 +54,7 @@ PyAPI_FUNC(int) PyEval_MergeCompilerFlags(PyCompilerFlags *cf);
 #endif
 
 PyAPI_FUNC(int) Py_AddPendingCall(int (*func)(void *), void *arg);
+PyAPI_FUNC(void) _PyEval_SignalReceived(void);
 PyAPI_FUNC(int) Py_MakePendingCalls(void);
 
 /* Protection against deeply nested recursive calls

diff --git a/Modules/signalmodule.c b/Modules/signalmodule.c
@@ -248,7 +248,7 @@ trip_signal(int sig_num)
         /* Set is_tripped after setting .tripped, as it gets
            cleared in PyErr_CheckSignals() before .tripped. */
         is_tripped = 1;
-        Py_AddPendingCall(checksignals_witharg, NULL);
+        _PyEval_SignalReceived();
     }
 
     /* And then write to the wakeup fd *after* setting all the globals and

diff --git a/Python/ceval.c b/Python/ceval.c
@@ -387,13 +387,28 @@ Py_AddPendingCall(int (*func)(void *), void *arg)
     return result;
 }
 
+void
+_PyEval_SignalReceived(void)
+{
+    /* bpo-30703: Function called when the C signal handler of Python gets a
+       signal. We cannot queue a callback using Py_AddPendingCall() since this
+       function is not reentrant (use a lock and a list). */
+    SIGNAL_PENDING_CALLS();
+}
+
 int
 Py_MakePendingCalls(void)
 {
     static int busy = 0;
     int i;
     int r = 0;
 
+    /* Python signal handler doesn't really queue a callback: it only signals
+       that an UNIX signal was received, see _PyEval_SignalReceived(). */
+    if (PyErr_CheckSignals() < 0) {
+        return -1;
+    }
+
     if (!pending_lock) {
         /* initial allocation of the lock */
         pending_lock = PyThread_allocate_lock();