{{ message }}
bpo-30766: Make CHECK_STATUS_PTHREAD signal-safe. - #2404
Closed
pitrou wants to merge 1 commit into
Closed
Conversation
vstinner
reviewed
Jun 26, 2017
Member
Author
There was a problem hiding this comment.
I don't know, I copied this macro from traceback.c.
| #define CHECK_STATUS_PTHREAD(name) if (status != 0) { fprintf(stderr, \ | ||
| "%s: %s\n", name, strerror(status)); error = 1; } | ||
| /* CHECK_STATUS_PTHREAD is async-signal-safe */ | ||
| #define CHECK_STATUS_PTHREAD(name) \ |
Member
There was a problem hiding this comment.
I never understood the purpose of these functions. Do we really need these checks? Why not replacing them with an assertion?
If you want to get them at runtime, maybe call Py_FatalError()?
Member
Author
There was a problem hiding this comment.
I don't know. I'm inclined not to remove them right now.
OTOH, this whole PR may be made obsolete by #2408.
Member
There was a problem hiding this comment.
I don't know. I'm inclined not to remove them right now. OTOH, this whole PR may be made obsolete by #2408.
Oh no, please finish your work. I like the idea of more reliable locks :-)
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.