{{ message }}
Conversation
Add Py_SetRef() and Py_XSetRef() functions to set a strong reference to a new object without creating a temporary dangling pointer. Rewrite the Py_SETREF() and Py_XSETREF() macros using respectively Py_SetRef() and Py_XSetRef() functions. Rewrite the Py_CLEAR() macro using the Py_XSetRef() public.
Member
Author
Member
Author
Member
|
I am not sure about this change really helps Rust, PyPy, HPy, etc. |
vstinner
changed the title
vstinner
marked this pull request as draft
November 11, 2020 00:46
Member
Author
There was no discussion about that. I prefer to convert this PR to a draft until I have more time to explain the overall rationale for https://bugs.python.org/issue42294 Also, Serhiy wrote that Py_SETREF() had some flaws, I didn't know that. I will have to dig into old discussions. |
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Py_SetRef() and Py_XSetRef() functions to set a strong reference
to a new object without creating a temporary dangling pointer.
Rewrite the Py_SETREF() and Py_XSETREF() macros using respectively
Py_SetRef() and Py_XSetRef() functions.
Rewrite the Py_CLEAR() macro using the Py_XSetRef() public.
https://bugs.python.org/issue42294