bpo-40077: Convert mmap to use heap types by erlend-aasland · Pull Request #23108 · python/cpython · GitHub
Skip to content

bpo-40077: Convert mmap to use heap types - #23108

Merged
vstinner merged 2 commits into
python:masterfrom
erlend-aasland:bpo-40077/mmap
Nov 3, 2020
Merged

bpo-40077: Convert mmap to use heap types#23108
vstinner merged 2 commits into
python:masterfrom
erlend-aasland:bpo-40077/mmap

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 2, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@corona10 or @vstinner, would you mind reviewing this?

https://bugs.python.org/issue40077

vstinner
vstinner approved these changes Nov 2, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This change looks really clean and valid. But I would appreciate another review, just to double check if I missed something.

@vstinner

vstinner commented Nov 2, 2020

Copy link
Copy Markdown
Member

corona10
corona10 approved these changes Nov 3, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to me also ;)

@corona10
corona10 requested a review from encukou November 3, 2020 01:38
shihai1991
shihai1991 approved these changes Nov 3, 2020
View reviewed changes

@shihai1991 shihai1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I have no other comments in here.

@erlend-aasland

erlend-aasland commented Nov 3, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, all of you! 🙏🏻

@vstinner
vstinner merged commit 74b4eda into python:master Nov 3, 2020
@vstinner

vstinner commented Nov 3, 2020

Copy link
Copy Markdown
Member

One less static type! Thanks @erlend-aasland.

@erlend-aasland
erlend-aasland deleted the bpo-40077/mmap branch November 3, 2020 09:40
@bedevere-bot

bedevere-bot commented Nov 3, 2020

Copy link
Copy Markdown

shihai1991 added a commit to shihai1991/cpython that referenced this pull request Nov 5, 2020
@shihai1991
Merge branch 'master' into bpo_41832
c267e35 
* master:
  bpo-42260: Add _PyInterpreterState_SetConfig() (pythonGH-23158)
  Disable peg generator tests when building with PGO (pythonGH-23141)
  bpo-1635741: _sqlite3 uses PyModule_AddObjectRef() (pythonGH-23148)
  bpo-1635741: Fix PyInit_pyexpat() error handling (pythonGH-22489)
  bpo-42260: Main init modify sys.flags in-place (pythonGH-23150)
  bpo-1635741: Fix ref leak in _PyWarnings_Init() error path (pythonGH-23151)
  bpo-1635741: _ast uses PyModule_AddObjectRef() (pythonGH-23146)
  bpo-1635741: _contextvars uses PyModule_AddType() (pythonGH-23147)
  bpo-42260: Reorganize PyConfig (pythonGH-23149)
  bpo-1635741: Add PyModule_AddObjectRef() function (pythonGH-23122)
  bpo-42236: os.device_encoding() respects UTF-8 Mode (pythonGH-23119)
  bpo-42251: Add gettrace and getprofile to threading (pythonGH-23125)
  Enable signing of nuget.org packages and update to supported timestamp server (pythonGH-23132)
  Fix incorrect links in ast docs (pythonGH-23017)
  Add _PyType_GetModuleByDef (pythonGH-22835)
  Post 3.10.0a2
  bpo-41796: Call _PyAST_Fini() earlier to fix a leak (pythonGH-23131)
  bpo-42249: Fix writing binary Plist files larger than 4 GiB. (pythonGH-23121)
  bpo-40077: Convert mmap.mmap static type to a heap type (pythonGH-23108)
  Python 3.10.0a2
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-40077: Convert mmap.mmap static type to a heap type (pythonGH-23108)
d7aae08
@corona10 corona10 mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@corona10 corona10 corona10 approved these changes
@shihai1991 shihai1991 shihai1991 approved these changes
@encukou encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland @vstinner @bedevere-bot @corona10 @shihai1991 @the-knights-who-say-ni