bpo-30616: Functional API of enum allows to create empty enums. by corona10 · Pull Request #2304 · python/cpython · GitHub
Skip to content

bpo-30616: Functional API of enum allows to create empty enums.#2304

Merged
ethanfurman merged 2 commits intopython:masterfrom
corona10:bpo-30616
Jun 21, 2017
Merged

bpo-30616: Functional API of enum allows to create empty enums.#2304
ethanfurman merged 2 commits intopython:masterfrom
corona10:bpo-30616

Conversation

@corona10
Copy link
Copy Markdown
Member

bpo-30616: Functional API of enum allows to create empty enums.

@corona10
Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. Please add one more test for:

Thing = enum.Enum('Thing', [])

@corona10
Copy link
Copy Markdown
Member Author

@ethanfurman Updated! Need to backport for 3.6?

Copy link
Copy Markdown
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you.

move addition to avoid conflict
@ethanfurman ethanfurman merged commit dcc8ce4 into python:master Jun 21, 2017
@bedevere-bot
Copy link
Copy Markdown

GH-2324 is a backport of this pull request to the 3.6 branch.

@ethanfurman
Copy link
Copy Markdown
Member

Add 3.5 backport label since 3.5 is still open to bug fixes.

@bedevere-bot
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants